Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variadic sugar for boolean static methods. #801

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

fortmarek
Copy link
Contributor

@fortmarek fortmarek commented Aug 29, 2020

Hi 馃憢

This is my first contribution, albeit a small one.

What I'd like to add is variadic argument support for static intializers of Signals, SignalProducers and Properties where Value == Boolean.
So, similar to how we write SignalProducer.combineLatest(producer1, producer2) we could write SignalProducer.any(producer1, producer2) - right now we have to do SignalProducer.any([producer1, producer2]) which seems unnecessarily verbose.

I have also change a few test cases to leverage this new feature

Checklist

  • Updated CHANGELOG.md.

@RuiAAPeres
Copy link
Member

I am slightly on the fence about this introduction, since the implementation, as-is is quite shallow. I will defer this to @andersio.

@andersio
Copy link
Member

@RuiAAPeres I think it's alright, basically sugar over the existing variant taking a Collection. Doesn't introduce new logic, and doesn't introduce overload conflicts.

@andersio andersio merged commit aac1d75 into ReactiveCocoa:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants