Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a SignalProducer.lift issue which may leak intermediate signals. #808

Merged
merged 5 commits into from
Oct 27, 2020
Merged

Fix a SignalProducer.lift issue which may leak intermediate signals. #808

merged 5 commits into from
Oct 27, 2020

Conversation

andersio
Copy link
Member

@andersio andersio commented Oct 27, 2020 •
edited
Loading

SignalProducer.lift might leak intermediate signals, if the upstream has been terminated, way before a downstream interruption is raised.

Checklist

  • Updated CHANGELOG.md.

@andersio andersio marked this pull request as ready for review October 27, 2020 13:15
Marcocanc
Marcocanc approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@Marcocanc Marcocanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@andersio andersio merged commit 2d46703 into master Oct 27, 2020
@andersio andersio deleted the anders/lift-bugfix branch October 27, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcocanc Marcocanc Marcocanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andersio @Marcocanc