Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnidirectionalBinding should return non optionals #834

Merged
merged 3 commits into from
Nov 19, 2021
Merged

UnidirectionalBinding should return non optionals #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c1ee29
UnidirectionalBinding should return non optionals
NicholasTD07 Jul 14, 2021
b6edc3f
Update CHANGELOG.md
NicholasTD07 Jul 14, 2021
06e1b35
Merge branch 'master' into patch-1
andersio Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# master
*Please add new entries at the top.*

1. Fixed issue where `SingalProducer.try(upTo:interval:count:)` shares state between invocation of `start` on the same producer.
1. The UnidirectionalBinding operator `<~` returns non optional values. (#834, kudos to @NicholasTD07)

1. Fixed issue where `SingalProducer.try(upTo:interval:count:)` shares state between invocation of `start` on the same producer. (#829, kudos to @sebastiangrail)

# 6.7.0
# 6.7.0-rc1
Expand Down
2 changes: 1 addition & 1 deletion Sources/UnidirectionalBinding.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ extension Signal.Observer {
@discardableResult
public static func <~
<Source: BindingSource>
(observer: Signal<Value, Error>.Observer, source: Source) -> Disposable?
(observer: Signal<Value, Error>.Observer, source: Source) -> Disposable
where Source.Value == Value
{
return source.producer.startWithValues { [weak observer] in
Expand Down