Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal.Event: changed to @frozen #841

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

NachoSoto
Copy link
Member

This enum isn't expected to change. It's important to mark it as @frozen
so that clients don't get warnings whem compiling with BUILD_LIBRARY_FOR_DISTRIBUTION,
which might be required in a future version of Carthage supporting Catalyst.
(See Carthage/Carthage#3235).

Checklist

  • Updated CHANGELOG.md.

This `enum` isn't expected to change. It's important to mark it as `@frozen`
so that clients don't get warnings whem compiling with `BUILD_LIBRARY_FOR_DISTRIBUTION`,
which might be required in a future version of Carthage supporting Catalyst.
(See Carthage/Carthage#3235).
@andersio
Copy link
Member

andersio commented Oct 5, 2021

It looks like by Library Evolution rules, adding or removing @frozen is always ABI breaking. So this would require a major version bump.

@andersio andersio merged commit e3916d7 into ReactiveCocoa:master Oct 5, 2021
@NachoSoto NachoSoto deleted the frozen branch October 30, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants