Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OSAllocatedUnfairLock instead of os_unfair_lock_ on supported platforms #856

Conversation

mluisbrown
Copy link
Contributor

@mluisbrown mluisbrown commented Oct 4, 2022

Fixes #854

For now macOS builds will still use os_unfair_lock_ until macOS 13 Ventura is released at which point this will need to be changed. It appears that you cannot refer to unreleased OS versions in @available and if #available statements 😞

NOTE:

CI is running Xcode 13.2.1 so tests will not test using OSAllocatedUnfairLock. CI should probably be updated to use Xcode 14.x. However, I ran tests locally with Xcode 14.0.1 and they passed. Looks like GitHub Actions will default to using Xcode 14.0.1 in the next few hours: actions/runner-images#6225

Checklist

  • Updated CHANGELOG.md.

@mluisbrown
Copy link
Contributor Author

mluisbrown commented Oct 4, 2022

Not sure why macCatalyst CI job is not working. It doesn't even start up 🤷

@NachoSoto
Copy link
Member

This looks great, thanks!

@mluisbrown
Copy link
Contributor Author

The macCatalyst job starts, but just seems to stall here:

image

That's the last output from xcodebuild that appears. It runs fine on my local machine.

@RuiAAPeres RuiAAPeres merged commit 90d3e58 into ReactiveCocoa:master Oct 6, 2022
@mluisbrown mluisbrown deleted the michael/migrate-to-os-allocated-unfair-lock branch October 6, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt OSAllocatedUnfairLock on iOS 16
3 participants