Add async helpers to Schedulers
#857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Credits to @pointfreeco for the work done in: https://github.com/pointfreeco/combine-schedulers ## Changes - Add new `async` APIs to `DateScheduler` to enable waiting for them in asynchronous contexts: + `sleep(for:leeway) async` + `sleep(until:leeway) async` + `timer(interval:leeway) async` - Add new `async` variants `TestScheduler`'s `advance` and `run` APIs, to enable waiting for them in asynchronous contexts: + `advance()` async` + `advance(by:) async` (`DispatchTimeInterval` and `TimeInterval`) + `advance(to:) async` + `run() async` - Refactor `TestScheduler.advance(to:)`'s loop condition to be based on `_currentDate` instead of `scheduledActions.count` to be consistent with the new `async` variant. - Add `NSRecursiveLock.withLock` implementation for older OS versions.
p4checo
force-pushed
the
add-async-helpers-to-schedulers
branch
from
4b350b7
to
d222a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits to @pointfreeco for the work done in:
https://github.com/pointfreeco/combine-schedulers
Changes
Add new
asyncAPIs toDateSchedulerto enable waiting for them in asynchronous contexts:sleep(for:leeway:) asyncsleep(until:leeway:) asynctimer(interval:leeway:) asyncAdd new
asyncvariantsTestScheduler'sadvanceandrunAPIs, to enable waiting for them in asynchronous contexts:advance()async`advance(by:) async(DispatchTimeIntervalandTimeInterval)advance(to:) asyncrun() asyncRefactor
TestScheduler.advance(to:)'s loop condition to be based on_currentDateinstead ofscheduledActions.countto be consistent with the newasyncvariant.Tests
Checklist