Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groupByProto signature is incorrect #33

Closed
patsissons opened this issue Aug 24, 2017 · 2 comments · Fixed by #34
Closed

groupByProto signature is incorrect #33

patsissons opened this issue Aug 24, 2017 · 2 comments · Fixed by #34

Comments

@patsissons
Copy link
Contributor

IxJS version: 2.0.1

Additional information:

the proto signature defines the outer iterable as a source param, instead of the this param.
@patsissons patsissons changed the title groupByProto signature is incorrect iterable groupByProto signature is incorrect Aug 24, 2017
@patsissons
Copy link
Contributor Author

I did a quick check on the remaining iterable operator adds and didn't see any other issues with this missing from the signature.

@patsissons patsissons changed the title iterable groupByProto signature is incorrect groupByProto signature is incorrect Aug 24, 2017
@patsissons
Copy link
Contributor Author

looks like it also affects the async variant.

patsissons pushed a commit to marinels/IxJS that referenced this issue Aug 24, 2017
fixing missing this in groupby operator prototype signatures
1103732 
resolves ReactiveX#33
@patsissons patsissons mentioned this issue Aug 24, 2017
Merged
patsissons pushed a commit to marinels/IxJS that referenced this issue Aug 24, 2017
fixing missing this in groupby operator prototype signatures
d7d438c 
resolves ReactiveX#33
trxcllnt pushed a commit that referenced this issue Aug 24, 2017
@trxcllnt
fix(groupBy): fixing missing this in groupBy operator prototype signa…
ff2ee18 
…tures

Fixes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing missing this in groupby operator prototype signatures marinels/IxJS
1 participant
@patsissons