Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Ensure return is called on AsyncIterators #348

Merged
merged 6 commits into from
Jul 26, 2022
Merged

[FIX] Ensure return is called on AsyncIterators #348

merged 6 commits into from
Jul 26, 2022

Conversation

trxcllnt
Copy link
Member

Fixes #280

mattpodwysocki
mattpodwysocki approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@mattpodwysocki mattpodwysocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattpodwysocki mattpodwysocki merged commit 72c37ec into master Jul 26, 2022
@mattpodwysocki mattpodwysocki deleted the fix/return-async-iterators branch July 26, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattpodwysocki mattpodwysocki mattpodwysocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timeout does not call return on source iterator
2 participants
@trxcllnt @mattpodwysocki