Schedule tasks with negative delays immediately as per Scheduler spec #347
Conversation
| scheduler.schedulePeriodicallyDirect(new CountingRunnable(), 1, -1, MINUTES); | ||
| fail(); | ||
| } catch (IllegalArgumentException e) { | ||
| assertEquals("period < 0: -1", e.getMessage()); |
There was a problem hiding this comment.
This should not be removed. A negative period makes no sense.
| worker.schedulePeriodically(new CountingRunnable(), 1, -1, MINUTES); | ||
| fail(); | ||
| } catch (IllegalArgumentException e) { | ||
| assertEquals("period < 0: -1", e.getMessage()); |
There was a problem hiding this comment.
This should not be removed. A negative period makes no sense.
There was a problem hiding this comment.
Where is this error message supposed to come from? Grepping RxAndroid and RxJava for "period < 0" gives no result. Moreover, wouldn't such test belong in RxJava?
I thought that these tests were disabled anyway, but I can reinstate them if you prefer.
There was a problem hiding this comment.
The test is ignored because it's currently not implemented natively. That still doesn't change the fact that its removal is unrelated to this PR.
There was a problem hiding this comment.
Fair enough. I will amend the PR.
There was a problem hiding this comment.
@JakeWharton This has been amended, I don't know if you expect a ping, but in any case here it is.
This fixes the issue in #346.
|
I'll do a point release tomorrow or Friday. Thanks! |
This fixes the issue in #346.