Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes. #476

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Conversation

besser82
Copy link
Contributor

@besser82 besser82 commented Feb 11, 2019

Fix 'Wcatch-value'.

This warning is reported by GCC 9.

Fix url to Doxygen binary tarball.

The files hosted on SourceForge are not going to fade away.

@kirkshoop
Copy link
Member

Thank you! Please make it a const ref.

This warning is reported by GCC 9.
@besser82
Copy link
Contributor Author

@kirkshoop Fixed in rebased commit.

@besser82 besser82 changed the title Fix Wcatch-value. Fix 'Wcatch-value'. Feb 11, 2019
The files hosted on SourceForge are not going to fade away.
@besser82 besser82 changed the title Fix 'Wcatch-value'. Small fixes. Feb 11, 2019
@besser82
Copy link
Contributor Author

@kirkshoop I've just added a patch that fixes the url to the Doxygen binary tarball to make TravisCI happy again.

@besser82 besser82 force-pushed the besser82/fix_Wcatch-value branch 4 times, most recently from db3f180 to 41c0daf Compare February 11, 2019 20:04
@kirkshoop
Copy link
Member

That is great! thanks for fixing the url

@kirkshoop kirkshoop merged commit 2254215 into ReactiveX:master Feb 12, 2019
@besser82 besser82 deleted the besser82/fix_Wcatch-value branch February 12, 2019 09:20
@besser82
Copy link
Contributor Author

That is great! thanks for fixing the url

You're welcome =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants