ReplaySubject - Manual Merge of Pull 218 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: rxjava-core/src/main/java/rx/operators/OperationTake.java
|
I have some open questions but want to get this merged so we can unblock progress in this area of subjects. |
benjchristensen
added a commit
that referenced
this pull request
Apr 18, 2013
ReplaySubject - Manual Merge of Pull 218
…-218-merge-replay Conflicts: rxjava-core/src/main/java/rx/operators/OperationTake.java rxjava-core/src/main/java/rx/operators/OperationTakeWhile.java rxjava-core/src/main/java/rx/subjects/Subject.java - moved UnsubscribeTester into a package private class as I'm still undecided on long-term placement of this and the OperatorTester class - merged DefaultSubject and PublishedSubject which were the same thing (lots more unit tests though from this pull request) - still not sure what the right name is for DefaultSubject/PublishSubject - renamed RepeatSubject to ReplaySubject to match .Net - tweaked unit tests with InOrder while reviewing them to understand behavior
|
RxJava-pull-requests #102 SUCCESS |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
…replay ReplaySubject - Manual Merge of Pull 218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual merge of ReplaySubject from pull request #218