1.x: Add vararg of Subscriptions to CompositeSubscription. #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you make sure you don't have that many space changes? |
|
Sure, I will fix it. |
klemzy
force-pushed
the
MultipleSubscriptionCompositeSubscription1x
branch
from
5ec27bf to
04f86ee
Compare
|
I have fixed formatting not to add indents on empty lines. |
| @@ -1,12 +1,12 @@ | |||
| /** | |||
| * Copyright 2014 Netflix, Inc. | |||
| * | |||
| * | |||
There was a problem hiding this comment.
Can you make sure these don't get changed?
|
akarnokd
changed the title
| @@ -344,4 +344,121 @@ public void testAddingNullSubscriptionIllegal() { | |||
| csub.add(null); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testAddAll() { | |||
There was a problem hiding this comment.
nit: test prefix is not needed, same for test below
|
Please rebase and squash. |
klemzy
force-pushed
the
MultipleSubscriptionCompositeSubscription1x
branch
from
3f8f3ea to
114f50c
Compare
|
This PR is a bit old. I'm 👍 with the API change but the test worries me too. I'm merging this and will post a PR that hardens that test (+ renames them for @artem-zinnatullin sake :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.