1.x: Added zip function with Observable array. #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return an Observable that emits the zipped results | ||
| * @see <a href="http://reactivex.io/documentation/operators/zip.html">ReactiveX operators documentation: Zip</a> | ||
| */ | ||
| public static <R> Observable<R> zip(Observable<?>[] ws, FuncN<? extends R> zipFunction) { |
There was a problem hiding this comment.
Please add:
* @since (if this graduates from Experimental/Beta to supported, replace this parenthetical
* with the release number)
*/
@Experimental
|
Thanks! Almost forgot, please also add a unit test that verifies this overload works with 0, 1, or a couple of sources. (You can add a unit test that, for example, loops from 0 to 31, generates an array with that many simple sources and checks if all source values actually zipped into the final value.) |
|
@akarnokd Sorry for the delay, I just added tests for 0, 1 and multiple array sizes, let me know if that's ok. |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4035 with @akarnokd