1.x: Change Completable.subscribe(onError, onComplete) to (onComplete, onError) #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| } | ||
|
|
||
| @Test(expected = NullPointerException.class) | ||
| public void subscribeTwoCallbacksSecondNull() { | ||
| normal.completable.subscribe(null, new Action0() { |
There was a problem hiding this comment.
Didn't catch that on initial PR, test was obviously copied from subscribeTwoCallbacksFirstNull and wasn't changed, second parameter should have been null.
artem-zinnatullin
changed the title
artem-zinnatullin
force-pushed
the
1x/az/completable-subscribe
branch
from
8912d87 to
55723da
Compare
|
Actually, I can deprecate old one and add new one as overload, it will have less impact on user code because only calls like Thoughts? |
Current coverage is 81.33%@@ 1.x #4140 diff @@
==========================================
Files 257 257
Lines 16811 16811
Methods 0 0
Messages 0 0
Branches 2547 2547
==========================================
+ Hits 13666 13673 +7
+ Misses 2243 2238 -5
+ Partials 902 900 -2
|
|
👍 |
|
Dynamic languages have trouble with the two methods, let's only have 1 method. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3851, closes #4137.