Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fixing JavaDoc warnings #5637

Merged
merged 1 commit into from
Oct 3, 2017
Merged

2.x: Fixing JavaDoc warnings #5637

merged 1 commit into from
Oct 3, 2017

Conversation

levaja
Copy link
Contributor

@levaja levaja commented Oct 3, 2017

Minor fixes for warnings reported by javadoc tool, mentioned in #5634

@akarnokd
Copy link
Member

akarnokd commented Oct 3, 2017

Nice. Could you also fix this:

:javadoc/home/travis/build/ReactiveX/RxJava/src/main/java/io/reactivex/observers/ResourceMaybeObserver.java:60: error: bad use of '>'

 *     .subscribeWith(new ResourceMaybeObserver<Integer>() {

Verified

This commit was signed with the committer’s verified signature.
atomaka Andrew Tomaka
@levaja
Copy link
Contributor Author

levaja commented Oct 3, 2017

Sure, amended!

@akarnokd akarnokd merged commit 3e11dc0 into ReactiveX:2.x Oct 3, 2017
This was referenced Oct 3, 2017
@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #5637 into 2.x will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5637      +/-   ##
============================================
+ Coverage     96.14%   96.26%   +0.11%     
+ Complexity     5845     5843       -2     
============================================
  Files           634      634              
  Lines         41539    41539              
  Branches       5752     5752              
============================================
+ Hits          39938    39986      +48     
+ Misses          647      608      -39     
+ Partials        954      945       -9
Impacted Files Coverage Δ Complexity Δ
...in/java/io/reactivex/subjects/BehaviorSubject.java 92.7% <ø> (+5.72%) 57 <0> (ø) ⬇️
...io/reactivex/subscribers/DisposableSubscriber.java 100% <ø> (ø) 9 <0> (ø) ⬇️
...a/io/reactivex/subscribers/ResourceSubscriber.java 100% <ø> (ø) 10 <0> (ø) ⬇️
...o/reactivex/observers/DisposableMaybeObserver.java 100% <ø> (ø) 7 <0> (ø) ⬇️
...ava/io/reactivex/processors/BehaviorProcessor.java 93.36% <ø> (+4.86%) 62 <0> (ø) ⬇️
...ava/io/reactivex/observers/DisposableObserver.java 100% <ø> (ø) 7 <0> (ø) ⬇️
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 113 <0> (ø) ⬇️
...ain/java/io/reactivex/subjects/PublishSubject.java 100% <ø> (ø) 41 <0> (ø) ⬇️
...io/reactivex/observers/ResourceSingleObserver.java 100% <ø> (ø) 8 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 506 <0> (ø) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126e7b5...0734940. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants