-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Add a sentence to documentation of take() operator. #5718
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5718 +/- ##
============================================
+ Coverage 96.23% 96.27% +0.03%
+ Complexity 5822 5821 -1
============================================
Files 634 634
Lines 41604 41604
Branches 5761 5761
============================================
+ Hits 40039 40054 +15
- Misses 624 625 +1
+ Partials 941 925 -16
Continue to review full report at Codecov.
|
@@ -13391,6 +13391,8 @@ public final void subscribe(FlowableSubscriber<? super T> s) { | |||
/** | |||
* Returns a Flowable that emits those items emitted by source Publisher before a specified time runs | |||
* out. | |||
* If time runs out before Flowable is finished, termination events would be balled on provided {@link Scheduler}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A <p>
would cleanly separate the first sentence and the rest of the Javadoc. Also the wording could use some refinement:
<p>
If time runs out before the {@code Flowable} completes normally, the {@code onComplete}
event will be signaled on the default {@code computation} {@link Scheduler}.
@@ -13418,6 +13420,8 @@ public final void subscribe(FlowableSubscriber<? super T> s) { | |||
/** | |||
* Returns a Flowable that emits those items emitted by source Publisher before a specified time (on a | |||
* specified Scheduler) runs out. | |||
* If time runs out before Flowable is finished, termination events would be balled on provided {@link Scheduler}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>
If time runs out before the {@code Flowable} completes normally, the {@code onComplete}
event will be signaled on the provided {@link Scheduler}.
@@ -11285,6 +11285,8 @@ public final void subscribe(Observer<? super T> observer) { | |||
/** | |||
* Returns an Observable that emits those items emitted by source ObservableSource before a specified time runs | |||
* out. | |||
* If time runs out before Observable is finished, termination events would be called on provided {@link Scheduler}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>
If time runs out before the {@code Observable} completes normally, the {@code onComplete}
event will be signaled on the default {@code computation} {@link Scheduler}.
@@ -11308,6 +11310,8 @@ public final void subscribe(Observer<? super T> observer) { | |||
/** | |||
* Returns an Observable that emits those items emitted by source ObservableSource before a specified time (on a | |||
* specified Scheduler) runs out. | |||
* If time runs out before Observable is finished, termination events would be called on provided {@link Scheduler}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>
If time runs out before the {@code Flowable} completes normally, the {@code onComplete}
event will be signaled on the provided {@link Scheduler}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreeing with david
#5716