-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.x: Add a sentence to documentation of take() operator #5719
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x #5719 +/- ##
===========================================
+ Coverage 84.18% 84.2% +0.02%
- Complexity 2886 2887 +1
===========================================
Files 290 290
Lines 18256 18256
Branches 2495 2495
===========================================
+ Hits 15368 15373 +5
Misses 2000 2000
+ Partials 888 883 -5
Continue to review full report at Codecov.
|
src/main/java/rx/Observable.java
Outdated
@@ -10535,6 +10535,8 @@ public final Subscription subscribe(Subscriber<? super T> subscriber) { | |||
/** | |||
* Returns an Observable that emits those items emitted by source Observable before a specified time runs | |||
* out. | |||
* If time runs out before Observable is finished, termination events would be called on provided {@link Scheduler}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A <p>
would cleanly separate the first sentence and the rest of the Javadoc. Also the wording could use some refinement:
<p>
If time runs out before the {@code Observable} completes normally, the {@code onComplete}
event will be signaled on the default {@code computation} {@link Scheduler}.
src/main/java/rx/Observable.java
Outdated
@@ -10559,6 +10561,8 @@ public final Subscription subscribe(Subscriber<? super T> subscriber) { | |||
/** | |||
* Returns an Observable that emits those items emitted by source Observable before a specified time (on a | |||
* specified Scheduler) runs out. | |||
* If time runs out before Observable is finished, termination events would be called on provided {@link Scheduler}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>
If time runs out before the {@code Observable} completes normally, the {@code onComplete}
event will be signaled on the provided {@link Scheduler}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreeing with David
#5716