Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: blockingX JavaDoc to mention wrapping of checked Exceptions #5951

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Apr 5, 2018

This PR adds an Error handling section to various blockingX operators to specify checked exceptions from their source will be wrapped into RuntimeExceptions.

@akarnokd akarnokd added this to the 2.2 milestone Apr 5, 2018
@codecov
Copy link

codecov bot commented Apr 5, 2018

Codecov Report

Merging #5951 into 2.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5951      +/-   ##
============================================
+ Coverage     98.27%   98.31%   +0.03%     
  Complexity     6020     6020              
============================================
  Files           656      656              
  Lines         44036    44036              
  Branches       6100     6100              
============================================
+ Hits          43278    43295      +17     
+ Misses          227      216      -11     
+ Partials        531      525       -6
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 142 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 535 <0> (ø) ⬇️
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 115 <0> (ø) ⬇️
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 171 <0> (ø) ⬇️
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 557 <0> (ø) ⬇️
...ternal/operators/observable/ObservablePublish.java 96.46% <0%> (-3.54%) 11% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
...ternal/operators/observable/ObservableFlatMap.java 86.26% <0%> (-1.6%) 3% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 98.26% <0%> (-0.87%) 2% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c281a...9244a67. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants