2.x: Fix Observable.concatMapSingle dropping upstream items #5972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal queue of
Observable.concatMapSingle
was incorrectly the bounded one from itsFlowable
counterpart, causing it to drop upstream items if the currentSingle
was delayed. The right queue forObservable
s is theSpscLinkedArrayQueue
.Added unit tests to both
concatMapSingle
andconcatMapMaybe
to verify the correct behavior.Fixes: #5971.