3.x: Reenable XFlatMapTest.maybeSingle, add missing Single operators #6893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenable the
XFlatMapTest.maybeSingle
and make sure all flatMap variants behave the same when the flow is cancelled/disposed while the mapper function is executing, thus the returned inner source doesn't get subscribed to at all.Resolves #6892
While adding the extra tests, I noticed two
flatMap
variant is missing fromSingle
:flatMap(Function<T, Single<U>>, BiFunction<T, U, R>)
flatMap(Function<T, Single<R>>, Function<Throwable, Single<R>>)
Lastly, the same combiner variant for
Maybe
received a marble diagram too:Related #5806