3.x: Document Schedulers.from's RejectedExecutionException handling #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #7150 +/- ##
============================================
- Coverage 99.55% 99.53% -0.03%
+ Complexity 6709 6706 -3
============================================
Files 745 745
Lines 47327 47327
Branches 6375 6375
============================================
- Hits 47117 47106 -11
- Misses 93 100 +7
- Partials 117 121 +4 Continue to review full report at Codecov.
|
ansip
approved these changes
Jan 18, 2021
vanniktech
approved these changes
Jan 19, 2021
| * because such circumstances prevent RxJava from progressing flow-related activities correctly. | ||
| * If the {@link Executor#execute(Runnable)} or {@link ExecutorService#submit(Callable)} throws, | ||
| * the {@code RejectedExecutionException} is routed to the global error handler via | ||
| * {@link RxJavaPlugins#onError(Throwable)}. To avoid shutdown-reladed problems, it is recommended |
There was a problem hiding this comment.
This might be a typo?
shutdown-reladed problems
There was a problem hiding this comment.
Yep, typos. Would you like to fix them?
There was a problem hiding this comment.
Here's the PR #7178.
| * because such circumstances prevent RxJava from progressing flow-related activities correctly. | ||
| * If the {@link Executor#execute(Runnable)} or {@link ExecutorService#submit(Callable)} throws, | ||
| * the {@code RejectedExecutionException} is routed to the global error handler via | ||
| * {@link RxJavaPlugins#onError(Throwable)}. To avoid shutdown-reladed problems, it is recommended |
There was a problem hiding this comment.
This might be a typo?
shutdown-reladed problems
| * because such circumstances prevent RxJava from progressing flow-related activities correctly. | ||
| * If the {@link Executor#execute(Runnable)} or {@link ExecutorService#submit(Callable)} throws, | ||
| * the {@code RejectedExecutionException} is routed to the global error handler via | ||
| * {@link RxJavaPlugins#onError(Throwable)}. To avoid shutdown-reladed problems, it is recommended |
There was a problem hiding this comment.
This might be a typo?
shutdown-reladed problems
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the 3 overloads of
Schedulers.fromto describe (in a concise manner) the cases when theExecutorwould throw aRejectedExecutionException. Such exceptions can't be reasonably handled from within RxJava.There are typically two cases when such exception would occur:
Operators such as
observeOnguarantee worker-confinement when callingonNext,onErrorandonComplete. A failure to schedule would at best bypass this confinement, notifying the downstream on the current thread, at worst cause overlapping execution downstream.The recommended workaround is to cancel all flows using the particular
Schedulerafter which the Executor can be shut down safely.Such temporary rejections are often used in traditional
Executorusages to drop work or pause the submission of work. In RxJava though, there is often no 1:1 correspondence to signals (onNext,onErrororonComplete). Some work may be correlated to severalonNexts, other work may be due to downstream requests. Dropping any such work may lead to inconsistent flow state or livelocks.The recommended workaround is to express limits on the execution via backpressure (e.g.,
Flowables).Resolves #7149