-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cocoapod #584
Comments
Xcode version is 7.3 |
Hello @hatjs880328, can you please try to clean the build folder or even delete the derived data and try to build again? If it doesn't work, can you give more details about this error, such as:
With all these information I think I can try to reproduce the error. |
pods version is 0.39.0 podfile like 👍 source 'https://github.com/CocoaPods/Specs.git' pod 'SnapKit', '~> 0.19.1' pod 'Alamofire', '~> 3.1.5' pod 'RxSwift', '~> 2.3.1' pod 'RxCocoa', '~> 2.3.1'
|
set Bitcode enabled |
ld: '/Applications/xcode7.3/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/Frameworks/XCTest.framework/XCTest' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. for architecture arm64 |
Haven't seen this ever so ¯_(ツ)_/¯ |
Hi @hatjs880328, according to
and I would suggest using new |
@kzaher As far as I can tell, this is an actual issue anytime you're building for device with RxTests in the project, as XCTest does not include bitcode. Can we just change the build flag in the Rx project to disable bitcode for the test utility components? |
Hi @tomburns , I guess we could, but I'm little confused. Last time I've tried to run unit tests on device: |
Anyway, I think we can close this one, unsure what to more here. I think this was caused by using RxTests in app binary. We can open new issues if this pops up in future. |
@kzaher FWIW this is still an issue; I've worked around it by adding a post-install hook to my pod file, but it would be much simpler to simply disable bitcode for the RxTests target and I don't see what the harm would be. You're correct that you can't run framework logic tests on device, however you can run unit tests injected into an application bundle on device, which is where I ran into this issue. |
RxBlocking's bitcode should be disabled as well if you decide to change them; as I understand it both are purely meant for use in test bundles, so this should be an acceptable change (until XCTest supports bitcode) |
Hi @tomburns , I'm little confused, if you install using CocoaPods, it shouldn't make any difference if I turn bitcode on or off in project, right? We are open to PRs. I'm not sure what action are you suggesting we should take. Bitcode is disabled for RxTests. |
Is there any way of disabling bitcode in podspec? |
I think you can add this line of code in your pod spec.
|
Thnx @retsohuang , I'll include this in RxTests for 2.5 because XCTest doesn't have bitcode turned on, and we can see how that will go :) |
Attempt #2 to close this issue. Feel free to reopen it if it's not working :) |
# By Krunoslav Zaher (23) and others # Via Krunoslav Zaher * 'master' of https://github.com/ReactiveX/RxSwift: (72 commits) Improves unit tests. Updates RxDataSources. Changes 2.5 to 2.5.0. Adds 2.5.0 changes to CHANGELOG. Makes `NSTextField` implement `RxTextInput`. Fixes Wikipedia automation tests. Improves delegate proxy messaging. ReactiveX#675 Turns off bitcode for RxTests. ReactiveX#584 Release 2.5 More comprensible `ActivityIndicator` Improve language in comment Use new Swift selector syntax in comment Update comment to use new non-deprecated method Fix argument key in comment Typo in comment 'extensions' with an 's' Improves documentation for `DelegateProxy.observe`. ReactiveX#654 Adds unit test for only setting different text values. Provides explanations for check. Fixes problems with two way binding that was caused by `rx_text` and always setting the text value even when the value was equal, and thus clearing the marked text state. ReactiveX#649 Add missing Next link ...
Module file was created by an older version of the complier;rebuild 'RxSwift' and try again :.............../X86_64.swiftmodule
The text was updated successfully, but these errors were encountered: