RxCocoa: UIImagePickerController extension causing iTunes Connect to require NSPhotoLibraryUsageDescription

[nighthawk]

Short description of the issue:

The UIImagePickerController in RxCocoa causes iTunes Connect to complain about missing NSPhotoLibraryUsageDescription key in the Info.plist file.

Self contained code example that reproduces the issue:

import RxCocoa

Xcode version:

Xcode 8 GM

Expected outcome:

Can upload binary to iTunes Connect without issues.

What actually happens:

iTunes Store complains about an invalid binary:

We have discovered one or more issues with your recent delivery for \(appName). To process your delivery, the following issues must be corrected:
This app attempts to access privacy-sensitive data without a usage description. The app's Info.plist must contain an NSPhotoLibraryUsageDescription key with a string value explaining to the user how the app uses this data.
Once these issues have been corrected, you can then redeliver the corrected binary.

I have confirmed that RxCocoa is the issue by deleting the extension and uploading again—this time it went through without issue.

The proposal is to remove the UIImagePickerController extensions from RxCocoa and, ideally, to move them to a repo in the RxSwift Community.

Related links:

• Apple Developer forum discussion builds getting rejected
• WWDC 2016 talk about usage description keys

Installation method:

• CocoaPods
• Carthage
• Git submodules

[kzaher]

Hi @nighthawk ,

Ok, I guess we can remove this from RxCocoa.

I think we also need to move CLLocation manager extensions. Has anyone had issues because of CLLocationManager extensions?

[nighthawk]

I've just uploaded a build for an app that does not use CLLocationManager but includes RxCocoa. iTC only complained about NSPhotoLibraryUsageDescription missing. So seems like the CLLocationManager extensions are safe to keep—at least for now.

[mohsenr]

I can confirm that I had the same issue, and removing RxImagePickerDelegateProxy.swift from the target fixed it. So @kzaher’s commit above should work.

[kzaher]

This should be fixed now, please reopen the issue if not.

[stonehouse]

I just integrated RxCocoa and RxSwift 2.6.1 into a project (to add better behaviour on search input). The changes were relatively minor, but upon submitting a built to TestFlight it was rejected because "NSPhotoLibraryUsageDescription" was missing from the Info.plist.

I tried submitting a build where I excluded UIImagePickerController+rx.swift and RxImagePickerDelegateProxy.swift from the target and this was accepted by TestFlight.

I'm still using 2.6.1 because the project is still on Swift 2.3. It seems like this is still an issue, at least in 2.6. I'm guessing this is fixed in RxCocoa 3?