Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rxdart_flutter tests to GHA #783

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Add rxdart_flutter tests to GHA #783

merged 5 commits into from
Feb 1, 2025

Conversation

hoc081098
Copy link
Collaborator

@hoc081098 hoc081098 commented Feb 1, 2025

This pull request includes several changes aimed at updating test configurations and dependencies, as well as refactoring imports and adding a new utility class. The most important changes include renaming and adding test scripts, removing a dependency, refactoring imports, and adding a new ValueSubject class.

Test configuration updates:

  • .github/workflows/rxdart-test.yml: Renamed the test job to Run rxdart tests and added a new job to run rxdart_flutter tests.
  • melos.yaml: Added a new script test-rxdart-flutter to run tests for the rxdart_flutter package.

Dependency updates:

Import refactoring:

  • packages/rxdart_flutter/test/src/not_replay_value_stream_builder_test.dart, packages/rxdart_flutter/test/src/not_replay_value_stream_consumer_test.dart, packages/rxdart_flutter/test/src/not_replay_value_stream_listener_test.dart: Refactored imports to replace rxdart_ext with a local import of rxdart_ext/value_subject.dart. [1] [2] [3]

New utility class:

@hoc081098 hoc081098 changed the title Update pubspec.yaml Add rxdart_flutter tests to GHA Feb 1, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.40%. Comparing base (81b909f) to head (11e960c).
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #783   +/-   ##
=======================================
  Coverage   93.40%   93.40%           
=======================================
  Files          78       78           
  Lines        2456     2456           
=======================================
  Hits         2294     2294           
  Misses        162      162           

@hoc081098 hoc081098 marked this pull request as ready for review February 1, 2025 07:59
@hoc081098 hoc081098 merged commit afd7f41 into master Feb 1, 2025
6 checks passed
@hoc081098 hoc081098 deleted the hoc081098-patch-1 branch February 1, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants