Skip to content

Commit

Permalink
chore(tools): remove script to generate operator patches
Browse files Browse the repository at this point in the history 
This is not being used anymore.
  • Loading branch information
@luisgabriel @kwonoj
luisgabriel authored and kwonoj committed Jan 29, 2016
1 parent aa35b2a commit bb308f4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 228 deletions.
1 change: 0 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"perf_micro": "node ./perf/micro/index.js",
"prepublish": "npm run build_all",
"generate_packages": "node .make-packages.js",
"generate_operator_patches": "tsc -outDir dist/ ./tools/generate-operator-patches.ts && node ./dist/generate-operator-patches.js --exec",
"commit": "git-cz",
"check_circular_dependencies": "madge ./dist/cjs --circular"
},
Expand Down
227 changes: 0 additions & 227 deletions tools/generate-operator-patches.ts
View file

This file was deleted.

3 comments on commit bb308f4

@jeffbcross
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it not useful? There are PRs now making changes to all patching operators that could've been done with this script to ensure consistency.

@luisgabriel
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it is useful. I was helping to keep the script up-to-date with the changes on the operators implementation (#1097, #1204, #1205). But after #1238 I assumed the patching operators would be manually maintained.

Also, with the new module augmentation stuff (#1284) I'm not sure how difficult it would be to adapt the script to export the operator types.

@benlesh
Copy link
Member

@benlesh benlesh commented on bb308f4 Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffbcross I think it served it's purpose. One of the problems was that the patch file output didn't always match 1-to-1 with the other implementations. It also forced strange file names in some cases.

Please sign in to comment.