Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(WIP): WIP on subscription refactor DO NOT MERGE #1099

Closed
wants to merge 1 commit into from
Closed

refactor(WIP): WIP on subscription refactor DO NOT MERGE #1099

wants to merge 1 commit into from

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Dec 19, 2015

Attn @trxcllnt, who I know is working on similar refactors.

I think we should just put up a different branch and work against that. It will likely take multiple PRs to straighten out this refactor.

@benlesh
Copy link
Member Author

benlesh commented Dec 19, 2015

Actually, @trxcllnt, I've done just that... this is merged into a subscription-refactor branch here. Let's try to work off of that. Basically the game is now to get all tests green and add tests around issues that other people have seen.

cc @staltz, @kwonoj

This is probably our biggest priority at the moment.

@benlesh benlesh closed this Dec 19, 2015
@benlesh
Copy link
Member Author

benlesh commented Dec 19, 2015

@trxcllnt
Copy link
Member

@Blesh we should start with #1065 merged in. I started my own branch from that PR on Friday and got fairly far, I think I might continue with that and see if I can solve it there, then merge that branch into this one.

@trxcllnt
Copy link
Member

@Blesh this is finished in my branch.

@staltz
Copy link
Member

staltz commented Dec 23, 2015

@trxcllnt since your commits touched ConnectableObservable, I'd recommend pulling in the tests I wrote in PR #1042 into your branch and make sure the tests pass there.

@benlesh
Copy link
Member Author

benlesh commented Dec 23, 2015

@trxcllnt did you want to submit a PR?

@benlesh benlesh deleted the normalsubs branch April 27, 2016 17:20
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants