-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(delayWhen): add delayWhen operator #1245
Conversation
Looks okay overall. I think we should try to get this method to use common logic such as |
Thanks. I'll give a try to refactor now to see if I can make it. |
In fact, I bet there are quite a few more operators that should probably use that code path to ensure they support Promises and the like. |
251434e
to
3ca9e89
Compare
OK, refactored by using |
eddd8bf
to
d2071f6
Compare
|
||
class DelayWhenSubscriber<T, R> extends OuterSubscriber<T, R> { | ||
private completed: boolean = false; | ||
private delayNotifiers: Array<DelayNotiferSubContext<T>> = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now tried to use simple array instead of map, subscription deletion via lookup & splice.
PR should be updated after #1252 checked in, marking as blocked for now. |
d2071f6
to
c61c1b5
Compare
updated PR to utilize innersub passed by notifyNext, also removes trycatcher as recent changes. |
c61c1b5
to
970819a
Compare
I'll check this in later today to see any other suggestions around. |
970819a
to
34faf6a
Compare
actually noticed code was using old trycatcher, updated PR to remove it. |
34faf6a
to
407a2a0
Compare
Merged with 17122f9. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes #1202
This PR implements
delayWhen
operator supports selector with subscription delay currentdelay
operator doesn't supports from RxJS4.