fix(Rx): remove kitchenSink and DOM, let Rx exports all #1663
Conversation
| "./doc/asset/devtools-welcome.js", | ||
| "./doc/scripts/custom-manual-styles.js", | ||
| "./doc/decision-tree-widget/dist/decision-tree-widget.min.js", | ||
| "./doc/scripts/setup-rx-script.js" | ||
| "./doc/decision-tree-widget/dist/decision-tree-widget.min.js" |
There was a problem hiding this comment.
/cc @staltz for document generate script related changes.
There was a problem hiding this comment.
@kwonoj is this blocking? Because the rest of this PR looks great to me.
There was a problem hiding this comment.
No, for visibility just in case if I miss anything. esdoc script is working on my local machine with this changes.
|
@kwonoj can you get rid of |
|
Will do that as well. just got back and caught conversation's ongoing. |
|
quick confirmation @Blesh - |
kwonoj
changed the title
|
Updated PR to remove |
|
LGTM |
|
Thanks for review / confirmation. I'll check this in late tonight to tomorrow. |
kwonoj
force-pushed
the
refactor-rx
branch
2 times, most recently
from
e9ec2f3 to
033497d
Compare
|
@kwonoj, be sure there is a breaking change message in the commit message. Since we're not putting those files out anymore. Will probably have to prefix it |
|
ah, thanks for pointing out. Let me update commit message now. |
kwonoj
changed the title
|
updated commit message as well. |
|
"Let Rx export all" :) |
closes ReactiveX#1650 BREAKING CHANGE: `Rx.kitchenSink` and `Rx.DOM` are removed, `Rx` export everything.
|
Merged with f5090b4. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
This PR removes
Rx.KitchenSink, letRxexports everything instead as well as does not populate build anymore.Related issue (if exists):
closes #1650