Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reduce/scan): both scan/reduce operators now accepts undefined itself as a valid seed #2050

Merged
merged 4 commits into from
Oct 24, 2016

Commits on Oct 19, 2016

  1. fix(scan): scan operator now accepts undefined itself as a valid se…

    …ed value
    
    Array#reduce supports `undefined` as a valid seed value, so it seems
    natural that we would too for scan
    
    ```js
    of(1, 2, 3).scan((acc, x) => acc + ' ' + x, undefined);
    // "undefined 1"
    // "undefined 1 2"
    // "undefined 1 2 3"
    ```
    
    fixes ReactiveX#2047
    jayphelps committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    d34e49b View commit details
    Browse the repository at this point in the history
  2. fix(reduce): reduce operator now accepts undefined itself as a vali…

    …d seed value
    
    Array#reduce supports `undefined` as a valid seed value, so it seems
    natural that we would too.
    
    ```js
    of(1, 2, 3).reduce((acc, x) => acc + ' ' + x, undefined);
    // "undefined 1 2 3"
    ```
    jayphelps committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    34e2e4f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2016

  1. Configuration menu
    Copy the full SHA
    0827628 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0df3dc9 View commit details
    Browse the repository at this point in the history