Observe on leak #2248
Merged
Observe on leak #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lf when unsubscribed There was a problem where subscriptions added to parent subscriptions would not remove themselves when unsubscribed, This meant that when Actions (which are subscriptions) were unsubscribed, they would still hang out in the _subscriptions list and live in memory when we didn't want them to related #2244
This was referenced Jan 4, 2017
trxcllnt
reviewed
Jan 4, 2017
| @@ -54,15 +54,13 @@ export class VirtualAction<T> extends AsyncAction<T> { | |||
| } | |||
|
|
|||
| public schedule(state?: T, delay: number = 0): Subscription { | |||
| return !this.id ? | |||
| super.schedule(state, delay) : ( | |||
| // If an action is rescheduled, we save allocations by mutating its state, | |||
There was a problem hiding this comment.
@Blesh can we keep this comment?
|
lgtm |
|
Is there an estimate on when the next patch version will be available? |
|
@kudoz very soon. This week or early next week. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscription.prototype.addremove themselves from the internal subscriptions list.fixes #2244