Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scheduler): prevent unwanted clearInterval #3226

Merged
merged 2 commits into from
Jan 16, 2018
Merged

fix(scheduler): prevent unwanted clearInterval #3226

merged 2 commits into from
Jan 16, 2018
+57 −4

Commits on Jan 13, 2018

  1. test(scheduler): add interval recycling tests

    @cartant
    cartant committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    60c8890 View commit details
    Browse the repository at this point in the history

  2. fix(scheduler): prevent unwanted clearInterval 

    In AsyncAction, this.pending was assigned before the call to
recycleAsyncId. That prevented the interval from being re-used resulting
in the interval being cleared and re-created for each notification.

Closes ReactiveX#3042
    @cartant
    cartant committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    53bdfe9 View commit details
    Browse the repository at this point in the history