feat(Symbol.iterator): no longer polyfilled #3389
Conversation
|
NOTE: The only worry I have with this change is that we're no longer watching for the weirdness with older versions of Firefox.. however that should be covered by a proper polyfill. |
Generated by 🚫 dangerJS |
---9.7KB-green.svg?style=flat-square){kind=icon}
---1.5KB-green.svg?style=flat-square){kind=icon}
src/internal/symbol/iterator.ts
Outdated
| polyfill. We don't want to throw on this, because it's not required | ||
| by the library. However it will provide clues to users on older | ||
| browsers why things like `from(iterable)` doesn't work. */ | ||
| if (!Symbol.iterator) { |
There was a problem hiding this comment.
I believe Symbol.iterator and Symbol itself were both defined in ES2015 so if Symbol.iterator isn't available it's likely that Symbol isn't either and this may error. 🤔
src/internal/symbol/iterator.ts
Outdated
| } | ||
|
|
||
| export const iterator = symbolIteratorPonyfill(root); | ||
| /** The native Symbol.iterator instance or a string */ | ||
| export const iterator = Symbol.iterator || '@@iterator'; |
There was a problem hiding this comment.
Same issue here Uncaught ReferenceError: Symbol is not defined
BREAKING CHANGE: We are no longer polyfilling `Symbol.iterator`. That would be done by a proper polyfilling library
benlesh
force-pushed
the
remove-symbol-iterator-polyfill
branch
from
1b14541
to
a3c8585
Compare
| polyfill. We don't want to throw on this, because it's not required | ||
| by the library. However it will provide clues to users on older | ||
| browsers why things like `from(iterable)` doesn't work. */ | ||
| if (!Symbol || !Symbol.iterator) { |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
BREAKING CHANGE: We are no longer polyfilling
Symbol.iterator. That would be done by a proper polyfilling library