Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier #3405

Closed
wants to merge 2 commits into from
Closed

Prettier #3405

wants to merge 2 commits into from

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Mar 7, 2018

The first commit sets up Prettier to run on all .ts files under ./src before any git commit. We can't run them on ./spec because it would ruin the offsets of the marble tests. :(

The second one does nothing but run prettier on everything under ./src, so it looks crazy, but it's just a reformat.

@benlesh benlesh requested a review from kwonoj March 7, 2018 23:35
@rxjs-bot
Copy link

rxjs-bot commented Mar 7, 2018

Warnings
⚠️

❗ Big PR (1)

Messages
📖

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

CJS: 1312.8KB, global: 698.2KB (gzipped: 114.3KB), min: 134.7KB (gzipped: 29.7KB)

Generated by 🚫 dangerJS

@benlesh benlesh added the blocked label Mar 8, 2018
@benlesh
Copy link
Member Author

benlesh commented Mar 8, 2018

Probably don't want to merge this until things settle down.

@benlesh
Copy link
Member Author

benlesh commented Mar 29, 2018

Closing this because of formatting issues with Prettier and pipeable operators. See prettier/prettier#4172

@benlesh benlesh closed this Mar 29, 2018
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants