Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google): Subclassing TestScheduler needs RunHelpers #5138

Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix(google): Subclassing TestScheduler needs RunHelpers #5138

merged 1 commit into from
Apr 3, 2020

Conversation

kolodny
Copy link
Member

@kolodny kolodny commented Nov 11, 2019

Until now, folks subclassing TestScheduler needed to run(callback: (helpers: RunHelpers... method. This was super brittle so we need to properly export this so it can be used more sanely

@kolodny
Copy link
Member Author

kolodny commented Nov 14, 2019

This PR is now ready for review

@benlesh benlesh added AGENDA ITEM Flagged for discussion at core team meetings and removed AGENDA ITEM Flagged for discussion at core team meetings labels Apr 3, 2020
@benlesh benlesh merged commit 927d5d9 into ReactiveX:master Apr 3, 2020
@kolodny
Copy link
Member Author

kolodny commented Apr 3, 2020

Yay, some mod somewhere in the bowels of google3 can now be removed

@jakovljevic-mladen jakovljevic-mladen mentioned this pull request Apr 3, 2020
Closed
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolodny @benlesh