-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Subscriber): avoid implicit any #517
Conversation
What version of the compiler? I haven't seen any complaints. |
should have finished the sentence ... "with noImplicitAny: true turned on" I guess it doesn't really matter, but ...
|
What sort of masochist would turn that on? |
The kind of masochist who thought that TypeScript's strong typing was one of the main attractions of that development path. What kind of lazy person neglects to set the type on a public API? If |
Whoa. LOL. People are so mean on the internet. He called me lazy! I was just teasing @robwormald. |
And I'm just teasing you. Sometimes this medium doesn't convey that very well. For which I apologize. p.s.: I have been running into a buzz saw of opposition to |
hugs, not bugs, y'all. |
@Blesh I believe I'm the culprit here, since I left off these annotations in the beginning. @robwormald sorry my affinity for laziness caused your headache! |
@trxcllnt, our only recourse is your summary execution. We can't have you making a mockery of this institution! We have to make an example for the others. |
@trxcllnt https://github.com/trxcllnt in the list of Typescript/Angular2/RxJS related headaches, this one is pretty much at the bottom of the list. After 3 days of smashing my head against the keyboard, I needed a win and this one looked good.
|
Rob, file issues for all of those headaches. There's no point in us using TypeScript if the library is hard to use with TypeScript |
Merged with 08faaa9 .. thanks @robwormald |
picky, but ts compiler complains about it if you're consuming the TS source.