Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Subscriber): avoid implicit any #517

Closed
wants to merge 1 commit into from

Conversation

robwormald
Copy link
Contributor

picky, but ts compiler complains about it if you're consuming the TS source.

@benlesh
Copy link
Member

benlesh commented Oct 13, 2015

What version of the compiler? I haven't seen any complaints.

@robwormald
Copy link
Contributor Author

should have finished the sentence ... "with noImplicitAny: true turned on"

I guess it doesn't really matter, but ...

On Oct 13, 2015, at 2:50 PM, Ben Lesh notifications@github.com wrote:

What version of the compiler? I haven't seen any complaints.


Reply to this email directly or view it on GitHub #517 (comment).

@benlesh
Copy link
Member

benlesh commented Oct 14, 2015

What sort of masochist would turn that on?

@wardbell
Copy link
Contributor

The kind of masochist who thought that TypeScript's strong typing was one of the main attractions of that development path.

What kind of lazy person neglects to set the type on a public API? If any is your best choice, make it any. At least you gave it some thought. At least you showed you cared.

@benlesh
Copy link
Member

benlesh commented Oct 14, 2015

Whoa. LOL. People are so mean on the internet. He called me lazy!

I was just teasing @robwormald.

@wardbell
Copy link
Contributor

And I'm just teasing you. Sometimes this medium doesn't convey that very well. For which I apologize.

p.s.: I have been running into a buzz saw of opposition to noImplicitAny of late.

@robwormald
Copy link
Contributor Author

hugs, not bugs, y'all.

@trxcllnt
Copy link
Member

@Blesh I believe I'm the culprit here, since I left off these annotations in the beginning. @robwormald sorry my affinity for laziness caused your headache!

@benlesh
Copy link
Member

benlesh commented Oct 14, 2015

@trxcllnt, our only recourse is your summary execution. We can't have you making a mockery of this institution! We have to make an example for the others.

@robwormald
Copy link
Contributor Author

@trxcllnt https://github.com/trxcllnt in the list of Typescript/Angular2/RxJS related headaches, this one is pretty much at the bottom of the list. After 3 days of smashing my head against the keyboard, I needed a win and this one looked good.

On Oct 14, 2015, at 1:13 AM, Paul Taylor notifications@github.com wrote:

@Blesh https://github.com/blesh I believe I'm the culprit here, since I left off these annotations in the beginning. @robwormald https://github.com/robwormald sorry my affinity for laziness caused your headache!


Reply to this email directly or view it on GitHub #517 (comment).

@benlesh
Copy link
Member

benlesh commented Oct 14, 2015

Rob, file issues for all of those headaches. There's no point in us using TypeScript if the library is hard to use with TypeScript

@benlesh
Copy link
Member

benlesh commented Oct 14, 2015

Merged with 08faaa9 .. thanks @robwormald

@benlesh benlesh closed this Oct 14, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants