fix: remove explicit types in toPromise spec #5261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As toPromise can resolve to undefined via the change in ReactiveX#5072.
benlesh
approved these changes
Jan 23, 2020
kwonoj
pushed a commit
to kwonoj/rxjs
that referenced
this pull request
Feb 5, 2020
As toPromise can resolve to undefined via the change in ReactiveX#5072.
martinsik
pushed a commit
to martinsik/rxjs
that referenced
this pull request
Feb 15, 2020
As toPromise can resolve to undefined via the change in ReactiveX#5072.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes explicit parameter types from arrow functions in the
toPromisespec. With the changes made in #5072,toPromiseis now typed as potentially resolving withundefined.The problem is currently breaking CI for all PRs.
Related issue (if exists): N/A