fix(zip): handle when unsubscribe is called from within next #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josepot
reviewed
May 4, 2022
src/internal/observable/zip.ts
Outdated
| @@ -88,7 +88,7 @@ export function zip(...args: unknown[]): Observable<unknown> { | |||
| // If any one of the sources is both complete and has an empty buffer | |||
| // then we complete the result. This is because we cannot possibly have | |||
| // any more values to zip together. | |||
| if (buffers.some((buffer, i) => !buffer.length && completed[i])) { | |||
| if (buffers !== null && buffers.some((buffer, i) => !buffer.length && completed[i])) { | |||
There was a problem hiding this comment.
nit:
Suggested change
| if (buffers !== null && buffers.some((buffer, i) => !buffer.length && completed[i])) { | |
| if (buffers?.some((buffer, i) => !buffer.length && completed[i])) { |
There was a problem hiding this comment.
I initially thought using an explicit !== null check is better as it results in a boolean which some people (including myself :-)) prefer. But I think your suggestion is more in line with the existing RxJS codebase.
I've changed it. Thanks for the review.
chrisguttandin
force-pushed
the
fix-6716
branch
2 times, most recently
from
a26936f
to
b1917c2
Compare
|
Sorry for tagging you @benlesh. I know it sucks. But given that this PR already had it's first anniversary and I rebased it a couple of times I hope it's okay. I would really appreciate if you could take a look. The PR only adds a single character and a test. Many thanks in advance. |
|
I just faced this issue in my code too and it would be great to have the PR merged 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes sure the error reported here (#6716) doesn't get thrown anymore.
BREAKING CHANGE: There are no breaking changes.
Related issue (if exists): #6716
I've added a test case which covers the bug but I wasn't sure if there might be a better way to test this. Please let me know if I need to change anything.