feat(map): removed deprecated map(project, thisArg) call pattern
#7158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
previously approved these changes
Jan 20, 2023
benlesh
dismissed
their stale review
skipWhile and skipUntil tests are broken. We need to figure out why first.
BREAKING CHANGE: `map(project, thisArg)` call pattern is no longer available. Use Function#bind method: `map(project.bind(thisArg))`
demensky
force-pushed
the
v8-remove-deprecated-map-signature
branch
from
457c915
to
c6b7562
Compare
benlesh
approved these changes
Jan 21, 2023
|
Awesome. Thanks, @demensky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
map(project, thisArg)call pattern is no longer available. Use Function#bind method:map(project.bind(thisArg))Related issue (if exists): #6367