-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix ng lint
and tools lint command in documentation
#7387
docs: fix ng lint
and tools lint command in documentation
#7387
Conversation
d5ff1e5
to
64a7386
Compare
@jakovljevic-mladen or @niklas-wortmann can you please take a look at this one? |
ping @jakovljevic-mladen or @niklas-wortmann |
Hey sorry for the delay, I am going to have a look at this after the holidays. Happy holidays everyone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tmair, thanks a lot for this PR.
I have left couple of comments that we could address, most of them being related to turning off no-non-null-assertion
, but also some other small issues that we could fix.
apps/rxjs.dev/src/app/custom-elements/api/api-list.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/rxjs.dev/src/app/custom-elements/resource/resource.service.spec.ts
Outdated
Show resolved
Hide resolved
64a7386
to
8c05623
Compare
I rebased the PR against master and addressed the review comments |
8c05623
to
a39f81e
Compare
One more question: Should we add the lint command to the build pipeline or should that be a separate PR once this PR is merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot again @tmair.
You can do that in the next PR. |
Description:
This PR tries to fix the
ng lint
and the toolslint
command of the documentation site (see also #7364 (review)).It is quite a substantial change, as introducing
eslint
into the build requires to change also changes in some of the source or tests files.Related issue (if exists):
This is trying to address the request for fixing
ng lint
sufaced in PR #7364 (review)