Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use a processor to transform the operator decision tree data #7388

Conversation

tmair
Copy link
Contributor

@tmair tmair commented Nov 27, 2023

Description:
This PR moves the generation of the decision tree into a dgeni processor, so that the decision tree will be generated as part of the documentation generation.

Related issue (if exists):
None

@benlesh
Copy link
Member

benlesh commented Dec 29, 2023

Hey @tmair ! I really appreciate all of this good work. Generally, I'm not the one that reviews anything to do with the docs app, so I've been deferring to @jakovljevic-mladen and @niklas-wortmann for that. This seems like a nice add though.

Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for adjusting this

Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmair, this PR is awesome, thank you a lot for merging Operator Decision Tree generator to the tools that already exist.

I have one comment regarding a file rename; everything else looks great. Also, conflicts need to be resolved.

apps/rxjs.dev/tools/transforms/config.js Outdated Show resolved Hide resolved
@tmair tmair force-pushed the decision-tree-generator-as-processor branch from 0543d3e to ce11b2e Compare January 3, 2024 14:52
@tmair
Copy link
Contributor Author

tmair commented Jan 3, 2024

I have one comment regarding a file rename; everything else looks great. Also, conflicts need to be resolved.

I rebased the PR and addressed the comment about the renaming of the file.

Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for making these changes @tmair 🎉

@jakovljevic-mladen jakovljevic-mladen merged commit 6cd8113 into ReactiveX:master Jan 5, 2024
3 checks passed
@tmair tmair deleted the decision-tree-generator-as-processor branch April 27, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants