Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mergeScan): support concurrency parameter for mergeScan #879

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Dec 3, 2015

  • expose concurrency parameter to interface of mergeScan
  • expand test coverage to test concurrency works

closes #868

- expose concurrency parameter to interface of mergeScan
- expand test coverage to test concurrency works

closes ReactiveX#868
@kwonoj
Copy link
Member Author

kwonoj commented Dec 3, 2015

Updated PR to add couple of more test to cover mergeScan 100%.

@staltz
Copy link
Member

staltz commented Dec 4, 2015

Looks great.

@benlesh
Copy link
Member

benlesh commented Dec 4, 2015

LGTM

@kwonoj
Copy link
Member Author

kwonoj commented Dec 4, 2015

Thanks, I'll check in myself.

@benlesh
Copy link
Member

benlesh commented Dec 4, 2015

Okay

@kwonoj
Copy link
Member Author

kwonoj commented Dec 4, 2015

Merged with fe0eb37, appreciate for review @staltz @Blesh :)

@kwonoj kwonoj closed this Dec 4, 2015
@kwonoj kwonoj deleted the feat-mergescan branch December 4, 2015 22:20
@benlesh
Copy link
Member

benlesh commented Dec 4, 2015

👍

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose concurrency parameter of mergeScan
3 participants