chore: extended plausible events to include editor #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 5 of 5 files. Overall, the semantic diff is 10% smaller than the GitHub diff.
|
|
joanise
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Looks good, and works, I've tested (temporarily opting in to analytics -- sorry for the noise there!).
I had to change our configuration on Plausible to add Editor and EditorTour as additional conversion goals, and now we see them in the Goals section.
To see the file formats, you have to click on Download in the Goal section, then you see stats by file format.
joanise
pushed a commit
that referenced
this pull request
Oct 16, 2024
joanise
pushed a commit
that referenced
this pull request
Oct 16, 2024
joanise
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
To extend plausible analytics coverage
Fixes?
zip downloads were not being recorded
Feedback sought?
sanity check
Priority?
High
Tests added?
n/a
How to test?
opt in, run test and check plausible
Confidence?
High
Version change?
no