feat: connect studio tour to editor tour #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 7 of 7 files. Overall, the semantic diff is 13% smaller than the GitHub diff.
|
|
|
This is OK, but it would be nice to bring the user's attention up to the Editor button in the top-right corner. Can we have an extra step in the Studio tour on the Editor button, with something like: |
deltork
force-pushed
the
dev.del/join-studio-and-editor-tours
branch
from
6e63b4a
to
3905e4a
Compare
|
@joanise, please add translations for fr and es. |
|
Thanks |
joanise
added a commit
that referenced
this pull request
Oct 16, 2024
* feat: connect studio tour to editor tour * chore: updated translations * fix: implemented feedback from Eric * chore: translations for the tour connection to the editor --------- Co-authored-by: Eric Joanis <eric.joanis@nrc-cnrc.gc.ca>
joanise
added a commit
that referenced
this pull request
Oct 16, 2024
* feat: connect studio tour to editor tour * chore: updated translations * fix: implemented feedback from Eric * chore: translations for the tour connection to the editor --------- Co-authored-by: Eric Joanis <eric.joanis@nrc-cnrc.gc.ca>
joanise
pushed a commit
that referenced
this pull request
Oct 18, 2024
* feat: connect studio tour to editor tour * chore: updated translations * fix: implemented feedback from Eric * chore: translations for the tour connection to the editor --------- Co-authored-by: Eric Joanis <eric.joanis@nrc-cnrc.gc.ca> (cherry picked from commit 8b89a03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Connecting studio tour to the editor tour
Fixes?
n/a
Feedback sought?
sanity check
Priority?
low
Tests added?
n/a
How to test?
Do the full tour in the pr preview
Confidence?
High
Version change?
patch