Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed data-cy to data-test-id #367

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

deltork
Copy link
Collaborator

@deltork deltork commented Oct 31, 2024

PR Goal?

Refactoring in anticipation of adding tests to studio

Fixes?

n/a

Feedback sought?

sanity check

Priority?

blocking

Tests added?

n/a

How to test?

Run web component tests npx nx run-many --targets=serve-test-data,build,serve,test:once --projects=web-component

Confidence?

High

Version change?

refactor

@deltork deltork requested a review from joanise October 31, 2024 13:41
Copy link
Contributor

github-actions bot commented Oct 31, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-31 19:49 UTC

Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joanise
Copy link
Member

joanise commented Oct 31, 2024

Actually, I approved this, but can you change the commit message? It should be a refactor: changed data-cy to data-test-id, not chore: ...

@joanise
Copy link
Member

joanise commented Oct 31, 2024

We tend to overuse chore:, but in this case it really doesn't apply.

@deltork deltork changed the title chore: changed data-cy to data-test-id refactor: changed data-cy to data-test-id Oct 31, 2024
@deltork deltork merged commit 58a4af7 into main Oct 31, 2024
1 check passed
@deltork deltork deleted the dev.del/refactor-test-id branch October 31, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants