Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added optional id to meta tag attributes #232

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

deltork
Copy link
Collaborator

@deltork deltork commented Jul 12, 2024

PR Goal?

fixing read-along DTD version 1.1 . The XML package is adding id to meta tag, adjusted the DTD to allow meta to have id attributes

Fixes?

fix DTD validation error

Feedback sought?

Priority?

HIGHEST

Tests added?

n/a

How to test?

Confidence?

HIGH

Version change?

n/a

Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for catching this!

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (29ec752) to head (b7f6e34).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files          21       21           
  Lines        1772     1772           
  Branches      321      321           
=======================================
  Hits         1546     1546           
  Misses        189      189           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanise joanise merged commit d928373 into main Jul 12, 2024
8 checks passed
@joanise joanise deleted the dev.del/DTD-1.1-hotfix branch July 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants