Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): exclude panphon 0.21 not compat with Python 3.8 #237

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Aug 19, 2024

PR Goal?

Deliberately exclude panphon 0.21 since it's not compatible with Python 3.8

@joanise joanise requested a review from roedoejet August 19, 2024 20:49
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (6087b74) to head (cb0487e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   87.60%   87.21%   -0.40%     
==========================================
  Files          21       21              
  Lines        1783     1783              
  Branches      323      323              
==========================================
- Hits         1562     1555       -7     
- Misses        183      189       +6     
- Partials       38       39       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dhdaines dhdaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to raise the max g2p version. Are we still compatible with g2p 1.1?

It's not wonderful to have a dependency on panphon which Studio doesn't actually use directly, but if we don't want to require the upcoming version of g2p as a minimum then I suppose we have to.

@joanise
Copy link
Member Author

joanise commented Aug 21, 2024

Eventually I'll want to have it as panphon>=0.19, !=0.21.0, !=0.21.1, !=0.21.2 assuming they release a patch with Aidan's PR.

And yeah, it's unfortunate to have to declare a g2p dependency here, but oh well is how I feel about it. Although maybe we should run a test: if studio never triggers the panphon import, maybe this PR in unnecessary? But no, we use panphon to confirm g2p output is valid IPA, I'm pretty sure that gets used by Studio.

@joanise
Copy link
Member Author

joanise commented Aug 21, 2024

And yes, I'm pretty sure we're still compatible with g2p 1.1.

@joanise joanise merged commit f114b8d into main Aug 21, 2024
8 checks passed
@joanise joanise deleted the dev.ej/fix-ci branch August 21, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants