Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to add properties and relationships to Alarms #250

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cbupp
Copy link
Collaborator

@cbupp cbupp commented Nov 9, 2023

Working through modeling BACnet and Niagara Edge Alarms, I'd like to propose:

  • Alarm:
    • ADD sourcePoint relationship: Alarm should reference the Point/Points that are the source of the Alarm.
  • Event
    • ADD eventIdentifier property: It's common for events to either generate a unique identifier, or use a reference number. This enables the events to be tracked and managed throughout it's lifecycle (important for ACK/clear on alarms)
    • ADD priority property: It's common for controller events to have an associated priority in order to understand how the system or operators should order their responses.
  • ExceptionEvent
    • ADD fromState and toState properties: Common pattern I'm seeing on controllers is capturing both from and to state, not just the generated message.

I'm still working through with my teams how to capture acknowledge and clear of exception events, and plan to expand this PR. I'm also planning on capturing common alarm configurations (High limit, deadband, etc)

@PeteHart
Copy link
Contributor

A question; the ExceptionEvent that is part of all alarms (as a lastKnownValue component) already includes a sourcePoint property so I don't understand why it's also needed on the Alarm itself?

Otherwise I'm ok with suggested changes.

@PeteHart PeteHart modified the milestones: Version 4.1, Version 4.x Jan 11, 2024
@sn3kyJ3di
Copy link

Does source need to be so specific? An alarm might be generated by a device and not have any explicit point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants