Addition of new class Space:Wing and ODR. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbupp
reviewed
Feb 7, 2024
cbupp
reviewed
Feb 7, 2024
|
Have updated the ODR but have in parallel received feedback that several deprecated brick:Locations are missing clear replacements in REC. Discuss further in Technical Committe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion to new class Space:Wing and associated ODR. Comments appreciated.
The new class is introduced as brick:Location is being deprecated in 1.4.
Note introduction of new folder for rec:SubBuilding class to accomodate new rec:Wing subclass.
Also note the recommendation to use rec:SubBuilding for new applications.