This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Add ActivityIndicator #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice mock! I'm not to familiar with the proptypes, but is there a way we can validate the colour, instead of checking it's just a string? |
|
Good catch! I updated the pull request so that it uses ColorPropType module to validate the color prop. It seems that the ColorPropType might also need some additions to make it match RN ColorTypeProp but I guess that is a concern for separate PR. |
|
Definately something for another PR, nice work though. Merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements mock for ActivityIndicator.