Warn legacy code users of invalid serial option combination (qzind#829)

RebeccaDeField · Jun 23, 2021 · 9e13b94 · 9e13b94
1 parent aca87ff
commit 9e13b94
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/qz/communication/SerialOptions.java b/src/qz/communication/SerialOptions.java
@@ -204,7 +204,12 @@ public SerialOptions(JSONObject serialOpts, boolean isOpening) {
             }
 
             if (!serialOpts.isNull("width")) {
-                try { responseFormat.fixedWidth = serialOpts.getInt("width"); }
+                try {
+                    responseFormat.fixedWidth = serialOpts.getInt("width");
+                    if (responseFormat.boundEnd.length > 0) {
+                        log.warn("Combining 'width' property with 'end' property has undefined behavior and should not be used");
+                    }
+                }
                 catch(JSONException e) { LoggerUtilities.optionWarn(log, "integer", "width", serialOpts.opt("width")); }
             }
         }